Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TH-242-2: Add ESLint to top level #102

Merged
merged 6 commits into from
Dec 5, 2024
Merged

TH-242-2: Add ESLint to top level #102

merged 6 commits into from
Dec 5, 2024

Conversation

eihabkhan
Copy link
Member

@eihabkhan eihabkhan commented Dec 5, 2024 •
edited
Loading

JIRA Ticket

Ticket: TH-242.

QA Steps

  • Go to /<any-theme>/assets/
  • Create a random js file (e.g: test.js)
  • start writing js code, for example const foo = 1
  • You should get an error for the missing semi column
  • You should get a warning for an unused variable

Note

Leave empty when you have nothing to say.

@eihabkhan eihabkhan self-assigned this Dec 5, 2024
@eihabkhan eihabkhan added the in progress Currently being developed. label Dec 5, 2024
@eihabkhan eihabkhan added Ready for review Requires a review from another developer. and removed in progress Currently being developed. labels Dec 5, 2024
@eihabkhan eihabkhan marked this pull request as ready for review December 5, 2024 11:28
ibrilBadreddine
ibrilBadreddine reviewed Dec 5, 2024
View reviewed changes
Copy link
Contributor

@ibrilBadreddine ibrilBadreddine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: does this change also resolve the CSS/SCSS formatting issue?

@eihabkhan
Copy link
Member Author

q: does this change also resolve the CSS/SCSS formatting issue?

No this only provide suggestions and point out errors/warnings to js code

@ibrilBadreddine ibrilBadreddine added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Dec 5, 2024
@eihabkhan eihabkhan merged commit 36da8a2 into master Dec 5, 2024
@eihabkhan eihabkhan deleted the TH-242-2 branch December 5, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrilBadreddine ibrilBadreddine ibrilBadreddine approved these changes

Assignees

@eihabkhan eihabkhan

Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eihabkhan @ibrilBadreddine